fix: automate TWS version extraction for release tags#2
Merged
Conversation
- Extract version from installed twslaunch jar during Docker build - Save version to .tws-version inside image and read back during make build - Update Makefile to use deferred expansion so VERSION resolves after build - Remove stale 335MB install-ibgateway.sh from repo root (downloaded fresh in Dockerfile) - Add .tws-version to .gitignore - Rename DOCKER_TOKEN to DOCKER_HUB_TOKEN in GitHub workflow
martinffx
force-pushed
the
fix/tws-version-extraction
branch
from
368b999 to
fe1c068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automates the extraction of the TWS version from the installed JAR files during the Docker build process. This fixes the stale hardcoded version (1030) in the Makefile release target.
Changes
Verification
make -n release now generates the correct tag: v1045-ibc3.23.0
Related
Fixes the version mismatch where the Makefile was still looking for the hardcoded Jts/1030 path.