Skip to content

chore(format): adopt shared prettier config - #28

Open
mark-brannan wants to merge 3 commits into
mainfrom
ccr-c9998ba3-kpyygm
Open

mark-brannan wants to merge 3 commits into
mainfrom
ccr-c9998ba3-kpyygm

Conversation

@mark-brannan

@mark-brannan mark-brannan commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Gives this repo the same prettier standard as the rest of the family (.prettierrc is byte-identical everywhere: printWidth 100, semi, single quotes, trailing commas).

Two commits, so the config diff stays reviewable:

  1. chore(format): .prettierrc, .prettierignore, prettier@3.6.2 pinned as a devDependency, format and format:check scripts, lockfile.
  2. style: format with prettier: 11 files, formatting only.

npm run format:check and npm test (31/31) pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_013tZDedCyFeyx2FHWZfMtvC

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013tZDedCyFeyx2FHWZfMtvC
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: mark-brannan/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fdb5aa43-4942-42a7-97f1-db317ac1e8f7

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Complexity: +0 across 3 functions

File Function Cyclomatic Δ Cognitive
web/app.js:159 (anonymous)#5 2 → 1 -1 2 → —
web/app.js:133 control 5 → 6 +1 9 → 9
test/calc.test.mjs:41 (anonymous)#3 1 → 1 +0 0 → —
All metrics
Function Metric Before After
web/app.js · (anonymous)#5 ccn 2 1
web/app.js · (anonymous)#5 cognitive 2 —
web/app.js · (anonymous)#5 halstead.N1 9.0 —
web/app.js · (anonymous)#5 halstead.N2 12.0 —
web/app.js · (anonymous)#5 halstead.bugs 0.01 —
web/app.js · (anonymous)#5 halstead.difficulty 2.73 —
web/app.js · (anonymous)#5 halstead.effort 229.09 —
web/app.js · (anonymous)#5 halstead.length 21.0 —
web/app.js · (anonymous)#5 halstead.n1 5.0 —
web/app.js · (anonymous)#5 halstead.n2 11.0 —
web/app.js · (anonymous)#5 halstead.vocabulary 16.0 —
web/app.js · (anonymous)#5 halstead.volume 84.0 —
web/app.js · (anonymous)#5 length 1 1
web/app.js · (anonymous)#5 mi.mi_original 147.5 —
web/app.js · (anonymous)#5 mi.mi_sei 137.3 —
web/app.js · (anonymous)#5 mi.mi_visual_studio 86.26 —
web/app.js · (anonymous)#5 nesting 0 0
web/app.js · (anonymous)#5 nloc 1 1
web/app.js · (anonymous)#5 params 0 0
web/app.js · (anonymous)#5 tokens 20 1
web/app.js · control ccn 5 6
web/app.js · control cognitive 9 9
web/app.js · control halstead.N1 127.0 129.0
web/app.js · control halstead.N2 128.0 128.0
web/app.js · control halstead.bugs 0.36 0.36
web/app.js · control halstead.difficulty 22.67 22.67
web/app.js · control halstead.effort 34809.29 35082.3
web/app.js · control halstead.length 255.0 257.0
web/app.js · control halstead.n1 17.0 17.0
web/app.js · control halstead.n2 48.0 48.0
web/app.js · control halstead.vocabulary 65.0 65.0
web/app.js · control halstead.volume 1535.7 1547.75
web/app.js · control length 24 30
web/app.js · control mi.mi_original 79.29 75.64
web/app.js · control mi.mi_sei 61.24 53.81
web/app.js · control mi.mi_visual_studio 46.37 44.23
web/app.js · control nesting 3 3
web/app.js · control nloc 22 28
web/app.js · control params 3 3
web/app.js · control tokens 234 255
test/calc.test.mjs · (anonymous)#3 ccn 1 1
test/calc.test.mjs · (anonymous)#3 cognitive 0 —
test/calc.test.mjs · (anonymous)#3 halstead.N1 9.0 —
test/calc.test.mjs · (anonymous)#3 halstead.N2 10.0 —
test/calc.test.mjs · (anonymous)#3 halstead.bugs 0.01 —
test/calc.test.mjs · (anonymous)#3 halstead.difficulty 2.78 —
test/calc.test.mjs · (anonymous)#3 halstead.effort 200.94 —
test/calc.test.mjs · (anonymous)#3 halstead.length 19.0 —
test/calc.test.mjs · (anonymous)#3 halstead.n1 5.0 —
test/calc.test.mjs · (anonymous)#3 halstead.n2 9.0 —
test/calc.test.mjs · (anonymous)#3 halstead.vocabulary 14.0 —
test/calc.test.mjs · (anonymous)#3 halstead.volume 72.34 —
test/calc.test.mjs · (anonymous)#3 length 1 1
test/calc.test.mjs · (anonymous)#3 mi.mi_original 148.51 —
test/calc.test.mjs · (anonymous)#3 mi.mi_sei 138.65 —
test/calc.test.mjs · (anonymous)#3 mi.mi_visual_studio 86.85 —
test/calc.test.mjs · (anonymous)#3 nesting 0 0
test/calc.test.mjs · (anonymous)#3 nloc 1 1
test/calc.test.mjs · (anonymous)#3 params 0 0
test/calc.test.mjs · (anonymous)#3 tokens 19 1

Measured 7 changed files, b3cf66a against 7022205. A measurement, not a gate.
Every metric is in the run's complexity artifact: complexity run

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013tZDedCyFeyx2FHWZfMtvC
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013tZDedCyFeyx2FHWZfMtvC
@mark-brannan mark-brannan changed the title chore: add prettier config chore(format): adopt shared prettier config Oct 11, 2026
@mark-brannan
mark-brannan marked this pull request as ready for review October 11, 2026 18:32
@claude

claude Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Claude finished @mark-brannan's task in 40s —— View job


Review of #28: adopt shared prettier config

No blocking findings. One toil finding, below.

What I ran

  • npm ci: clean, 0 vulnerabilities.
  • npm test: 31/31 pass.
  • git diff origin/main...HEAD -- web/app.js README.md SECURITY.md CONTRIBUTING.md package-lock.json package.json: read in full. I did not read the diffs for bin/, lib/, test/ or web/index.html.

What I could not run

  • npm run format:check and npm run build:web were denied by the sandbox's command approval. I did not verify that the tree is prettier-clean, or that the web build still works after the web/index.html reformat (394 added / 173 removed lines).
  • npm test includes test/web-bundle.test.mjs, which passes. That is indirect evidence for web/app.js, not for the HTML.
  • The public-issue-guard.sh seeding did not land, as the task notes warned. Bash calls were gated per command.

Checked by reading

  • Credentials: none in the diff. The lockfile only adds the prettier@3.6.2 integrity hash, which is not a credential.
  • Formatting-only claim: the web/app.js diff is wrapping, trailing commas and expanded nested arrays. I saw no logic change. The complexity bot's control ccn 5→6 and its token and length deltas look like measurement noise from the re-wrapped h(...) and addEventListener calls, not new branches.
  • Docs: README, SECURITY and CONTRIBUTING changes are table padding and *x*→_x_ only. They add no prose, so .writing-rubric.md has nothing to cite. The rubric's 110-character limit is about rendered cell width, not source padding.
  • Decision history in comments or md: none added. .prettierignore has one why-comment for .github, which is fine.
  • Repo conventions: the repo has no CLAUDE.md or AGENTS.md.

Findings

  • toil: nothing runs format:check in CI, and .github/workflows has only release-please.yml. The standard will drift after merge. Fix: add a npm run format:check step to the existing test workflow, or call the shared one in mark-brannan/.github. I can't edit workflows. Skip it if the fleet intentionally leaves enforcement to a local hook.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants