Repository navigation
Fix build warnings; copies from mantle #320 (Luau 0.746, QuickJS 0.18.0, API 1.89) - #147
Merged
Merged
Conversation
…est vectors - MantleVehicleBodySplit: use UStaticMesh::SetAutoComputeLODScreenSize(false) instead of the deprecated bAutoComputeLODScreenSize member (UE 5.7). - MantleWeaponFitTest: start the point vectors at zero where they are declared, so MSVC no longer flags them as possibly uninitialized. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SpillVanish case deletes its three spilled files on purpose, and the queue-file case names a gone.bin it never writes, so the engine's streaming reader warns "Failed to read file" for each. Both tests now declare those warnings as expected (3 and 1), so the test log no longer shows them as noise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ipt API 1.89 Synced with tools/copies/check_copies.py --sync from git archive of mantleplatform/mantle@658da9a (457 copied files match their home): - ThirdParty/LuauLib: vendored Luau 0.738 -> 0.746, plus LuauWarnings.h. - ThirdParty/QuickJSLib: quickjs-ng v0.16.2 -> v0.18.0, Mantle patches 0001/0002 regenerated. - MantleScriptTools: the QuickJS interrupt handler takes a JSContext. - Resources/ScriptApi: generated typings at minor 89. Build.cs files are not copied, so their rules are mirrored by hand: LuauLib.Build.cs force-includes LuauWarnings.h (C4127/C4310/C4324/C4389/ C4457/C4505/C4702, reasons in that header) and defines _CRT_SECURE_NO_WARNINGS (C4996 in luaO_chunkid/scanformat, which size their buffers first). QuickJSLib.Build.cs only gets its version comment; 0.18.0 builds with no warnings. Mantle-PR: mantleplatform/mantle#320 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MantleCore half of the build-warnings pass. mantle side: mantleplatform/mantle#320. This merges first.
Mantle-PR: mantleplatform/mantle#320
Changes
UStaticMesh::SetAutoComputeLODScreenSize(false)in place of the deprecatedbAutoComputeLODScreenSizemember (C4996).gone.binit never writes). They now declare the engine'sFailed to read filewarnings as expected (3 and 1), so the test log stops showing them as noise.check_copies.py --syncfrom agit archiveof that commit; all 457 copied files match their home:LuauWarnings.h.JSContext.LuauLib.Build.csforce-includesLuauWarnings.hand defines_CRT_SECURE_NO_WARNINGS, the same as mantle'sMantleGameLuauLib.Build.cs. The reason for each warning is in that header.QuickJSLib.Build.csonly gets its version comment, because 0.18.0 builds clean.Not in this PR
The ~90
package was marked as deleted in editor, but has been modified on disklines (AssetRegistry, from weapon builder, rigid-mesh and asset-cleanup tests) are still there.AssetDeletedmarks the package empty, and then the directory-watcher change from the save just before arrives and trips the warning.Testing
Run with D:\Mantle\mantle at 658da9acd plus this branch, headless with
-nullrhi:Mantle.Script.*(including ScriptTools, ScriptCatalog, ScriptPackages and ScriptPoint;Mantle.Script.Api.ManifestCopiesAreCurrentpasses)Mantle.Animation.*and Grab.ComponentFailed to read filewarnings and 0 build warnings.🤖 Generated with Claude Code