PyQt6 Migration (draft) - DO NOT MERGE #3154
Open
ashleymeigh2 wants to merge 9 commits into
Open
Conversation
- Changed all PyQt5 imports to PyQt6 equivalents across the codebase - Updated environment files (environment.yml, environment-dev.yml, meta.yaml, etc.) to require PyQt6
- Updated QAction, QActionGroup, QShortcut imports and usages - Changed QPalette role usages to QPalette.ColorRole.* - Updated QImage.Format usages to QImage.Format.* - Refactored all Qt enum usages (Orientation, AlignmentFlag, MouseButton, ItemDataRole, etc.) to new PyQt6 style - Fixed IndentationError and removed duplicate lines in main/view.py - Ensured all enum and role usages follow PyQt6 API requirements
847bffb to
d953922
Compare
- Updated qt_test_message_handler.py to use QtCore.QtMsgType.QtInfoMsg, QtWarningMsg, etc., resolving AttributeError for Qt message types in PyQt6. - Replaced deprecated QtWidgets.qApp with QApplication.instance() in spectrum_viewer/view.py for event processing.
ff84212 to
9b2451e
Compare
Removed pyqt6-sip because pyqt already manages the correct SIP version Updated vtk pin to ensure Qt6-compatible VTK builds are selected Removed explicit hdf5 pin to avoid ABI/dependency conflicts with h5py Kept qt-material=2.14 unchanged since it should still work with Qt6 unless styling issues appear
9b2451e to
31c9aef
Compare
cedc339 to
4405b98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Closes #
Description
This PR migrates the codebase from Qt5/PyQt5 to Qt6/PyQt6.
Checklist of migration steps:
Developer Testing
Acceptance Criteria and Reviewer Testing