CIL recon: adding implicit formulation of TV with warm start#1972
Draft
paskino wants to merge 1 commit into
Draft
CIL recon: adding implicit formulation of TV with warm start#1972paskino wants to merge 1 commit into
paskino wants to merge 1 commit into
Conversation
Collaborator
|
Thanks, I'll take a look at this next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
closes #1971
Description
Adds the possibility to run TV regularised LS with the implicit formulation of (S)PDHG. This will require some UI changes, and in future it can be used to define different regularisers (like TGV), although the latter will require additional UI changes + the new dependency on the CCPi Regularisation.
Testing
Describe the tests that were used to verify your changes.
Acceptance Criteria
How should the reviewer test your changes?
Documentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes