Recover struct field tags for issue #37#97
Merged
Conversation
- Add TaggedStruct with exported, unexported, and untagged fields to testproject - Add comprehensive tag test suite (positive + negative cases) - Positive tests intentionally fail — implementation not yet written
- Extend readRTypeName to return (name, tag, err) - Go 1.7-1.16: read flag byte from name_len_raw[0], extract tag after name bytes - Go 1.17+: read flag byte separately, use distinct nameVarintLen/tagVarintLen to avoid shadowing - Fix flag check: flag&(1<<1)!=0 instead of ==3, catches unexported fields with tags - Wire tag into struct Reconstructed output in ParseType_impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to recover struct field tags
includes tests and Implementation
closes #37