Dropdown: single divider for add-label + View-all expands inline#48
Merged
Conversation
Labels demo: drop the extra divider line above the Add-label row so a single divider (the sticky search's own bottom rule) sits between the search field and the new-label item, per designer correction (Figma 64-626). Filters demo: a viewAll section now previews its first rows and the View-all toggle reveals the remaining rows inline (becoming Show less), instead of being a styled no-op. Keyboard-accessible (menuitem, activated via Enter in the play test) with aria-expanded reflecting the state. Closes #31
|
📚 Storybook preview: https://pr-48-propel-storybook.vamsi-906.workers.dev |
There was a problem hiding this comment.
Pull request overview
Updates the Dropdown Storybook demos to reflect designer follow-ups from #16 / issue #31: remove the extra divider in the Labels demo, and make the Filters demo “View all” control actually expand/collapse additional rows inline.
Changes:
- Labels demo: removed the extra manual
border-tdivider so only the search header’s divider remains before “Add label”. - Filters demo: implemented inline expand/collapse for “View all (N)” → “Show less”, including
aria-expanded, and updated the play test to validate keyboard activation + collapse.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bhaveshraja
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Designer follow-up from @bhaveshraja's review on #16. Resolves #31.
Changes
border-tline that sat above the "Add label" row. The stickyDropdownSearchalready draws its own bottom rule, so a single divider now separates the search field from the new-label item (Figma64-626), matching the designer's correction (one line, not two).viewAll(Assignee) section now previews only its first rows; the previously no-op "View all (N)" link reveals the remaining rows inline and becomes "Show less" to collapse them again. It's aDropdownItemmenuitem, so it stays keyboard-focusable/operable, andaria-expandedreflects the inline-expansion state. Filter header click-to-collapse is unchanged (designer confirmed working).Verification
vp checkclean (format + lint + types).vp run -r testgreen 3x (87 tests, 12 dropdown). The Filters play test now exercises View-all via keyboard (Enter) and asserts the hidden assignees appear, then collapse on "Show less".vp run -r buildpasses (attw clean).