Skip to content

Fix: dropdown demo Checkbox missing required tone (unbreak main)#36

Merged
lifeiscontent merged 1 commit into
mainfrom
fix/dropdown-checkbox-tone
Jun 10, 2026
Merged

Fix: dropdown demo Checkbox missing required tone (unbreak main)#36
lifeiscontent merged 1 commit into
mainfrom
fix/dropdown-checkbox-tone

Conversation

@lifeiscontent

@lifeiscontent lifeiscontent commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

main's typecheck broke once #16 (Dropdown, uses Checkbox) and #22 (Checkbox tone required) both merged, since the dropdown demo story's Checkbox had no tone. Adds tone="neutral". Restores green main.

@lifeiscontent
Fix: dropdown demo Checkbox missing required tone
5eae35f 
main typecheck broke once #16 (Dropdown, uses Checkbox) and #22 (Checkbox
tone required) both merged. The dropdown demo PanelCheckboxRow Checkbox had
no tone. Add tone="neutral".
@lifeiscontent lifeiscontent self-assigned this Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📚 Storybook preview: https://pr-36-propel-storybook.vamsi-906.workers.dev

Copilot AI reviewed Jun 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores main typecheck by updating the Dropdown Storybook demo to comply with the Checkbox API change that made tone a required prop.

Changes:

  • Add tone="neutral" to the Checkbox used in PanelCheckboxRow within dropdown.stories.tsx.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lifeiscontent

lifeiscontent commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

This is a one-line build hotfix that unblocks main (typecheck broke after #16 + #22 both merged, a dropdown demo Checkbox was missing the now-required tone). vp check + build are green. It needs one approving review to merge, and I'm the author so I can't self-approve. @bhaveshraja a quick approve here would restore green main (and unblock the 6 open PRs that currently inherit the break). No design change in this one.

@lifeiscontent lifeiscontent merged commit edd5ee9 into main Jun 10, 2026
3 checks passed
@lifeiscontent lifeiscontent deleted the fix/dropdown-checkbox-tone branch June 10, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@bhaveshraja bhaveshraja bhaveshraja approved these changes

Assignees

@lifeiscontent lifeiscontent

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lifeiscontent @bhaveshraja