Resolve transitive Dependabot alerts#113
Merged
Merged
Conversation
|
📚 Storybook preview: https://pr-113-propel-storybook.vamsi-906.workers.dev |
There was a problem hiding this comment.
Pull request overview
This PR addresses transitive Dependabot security alerts in the monorepo’s tooling/dev dependency graph by adding pnpm overrides that force patched versions of specific vulnerable packages.
Changes:
- Add pnpm workspace overrides to pin patched versions of
esbuild,ws, andjs-yaml. - Regenerate
pnpm-lock.yamlto reflect the overridden resolutions across Storybook/Vite+/Wrangler/Miniflare/Changesets dependency paths.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds global pnpm overrides to force patched transitive versions. |
| pnpm-lock.yaml | Updates lockfile resolutions to match the new override pins (esbuild/ws/js-yaml). |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
+20
| overrides: | ||
| esbuild: 0.28.1 | ||
| js-yaml: 4.2.0 | ||
| vite: "catalog:" | ||
| vitest: "catalog:" | ||
| ws: 8.21.0 |
lifeiscontent
added a commit
that referenced
this pull request
Jun 17, 2026
…114) The ws, js-yaml, and esbuild pins from #113 were global overrides, so they would silently apply to any future or runtime dependency path, not just the tooling chains that actually pull the vulnerable versions. Replace them with pnpm selector overrides targeting exactly the chains the lockfile reports: ws -> miniflare, storybook, @vitest/browser, @voidzero-dev/vite-plus-test js-yaml -> @changesets/parse, read-yaml-file esbuild -> storybook, @storybook/csf-plugin, vite, @voidzero-dev/vite-plus-core, wrangler The lockfile still resolves each package to a single patched version (ws@8.21.0, js-yaml@4.2.0, esbuild@0.28.1), so the security outcome is unchanged while the blast radius stays explicit and small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
These are development/tooling dependency paths. Upstream owners currently still resolve vulnerable versions through wrangler/miniflare, Storybook/Vite+, and Changesets, so this uses narrow pnpm overrides instead of waiting for upstream releases.
Validation