docs: state the browser-support baseline + browserslist#108
Merged
Conversation
|
📚 Storybook preview: https://pr-108-propel-storybook.vamsi-906.workers.dev |
There was a problem hiding this comment.
Pull request overview
This PR documents @plane/propel’s minimum supported browser baseline (driven by Tailwind v4 and modern color token features) and aligns the package’s build targeting via a browserslist entry.
Changes:
- Add a “Browser support” section to the package README, including a minimum-version table and rationale.
- Add a
browserslistfield topackages/propel/package.jsonto codify the same baseline for tooling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/propel/README.md | Adds documented browser-support baseline and rationale for unsupported versions. |
| packages/propel/package.json | Adds browserslist to align build/tooling targets with the documented baseline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
propel never declared which browsers it targets, yet its color tokens use `oklch()` and `color-mix()` and it's built on Tailwind v4 — all of which set a hard floor. Per MDN's compat data the binding constraints are Tailwind v4 (Safari 16.4, Firefox 128) and `color-mix()` (Safari 16.2), so the effective baseline is Chrome/Edge 111+, Firefox 128+, Safari/iOS 16.4+, no IE. Add a "Browser support" table to the README so consumers know what they get (older Safari/Firefox render the tokens incorrectly), and a matching `browserslist` so propel's own build tooling targets the same set. The tokens use the plain, well-supported forms (literal `oklch()`, two-color `color-mix(in oklch, ...)`), not the relative/variadic syntaxes that have partial support, so nothing in the CSS needed changing.
lifeiscontent
force-pushed
the
docs/browser-support
branch
from
4bbbfa1 to
52bb465
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
propel declared its browser support nowhere, even though its color tokens use
oklch()andcolor-mix()and it builds on Tailwind v4 — each of which sets a hard floor a consumer can hit.Using MDN's Browser Compatibility Data, the binding constraints are:
oklch()(base tokens)color-mix()(alpha/tint tokens)No IE. So this adds:
browserslistinpackage.json, so propel's own build tooling targets the same setNo CSS changes: the tokens use the plain
oklch()/ two-colorcolor-mix(in oklch, ...)forms, not the relative (oklch(from ...)) or variadic syntaxes that carry partial-support caveats. Verified withvp check.