Align toolchain to a fresh Vite+ project#105
Merged
Merged
Conversation
The repo was scaffolded with a stale pnpm pin and without the toolchain deps a Vite+ library declares. Match what `vp create` produces today. - packageManager: pnpm@10.0.0 -> pnpm@11.7.0 - Declare the toolchain devDeps a fresh Vite+ library ships: typescript, @typescript/native-preview, @types/node, bumpp, vite-plus - Add the check / prepublishOnly / test package scripts - Move onlyBuiltDependencies (the package.json `pnpm` field) to `allowBuilds` in pnpm-workspace.yaml, which is where pnpm 11 reads it; esbuild/sharp/workerd are allowed to build - Run the story tests via `vp test` (the Vite+ convention) instead of a custom Vite Task that shelled out to the raw `vitest` binary, which pnpm 11 no longer links into node_modules/.bin - .gitignore: stop ignoring .vscode/settings.json Verified on pnpm 11.7.0: `vp check` clean, `vp run -r test` 700/700 across the four themes, `vp run -r build` clean (attw passes).
|
📚 Storybook preview: https://pr-105-propel-storybook.vamsi-906.workers.dev |
There was a problem hiding this comment.
Pull request overview
Aligns the repo’s toolchain with the current Vite+ monorepo scaffold by updating the pnpm pin, moving pnpm’s native-build allowlist to the pnpm 11 location, and switching story tests to the Vite+ (vp) convention.
Changes:
- Update root
packageManagertopnpm@11.7.0and move build allowlisting topnpm-workspace.yaml. - Update
@plane/propelscripts to addcheck/test/prepublishOnlyand run tests viavp test. - Remove the custom Vite
run.tasks.testtask frompackages/propel/vite.config.tsand re-resolve the lockfile under pnpm 11.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pnpm-workspace.yaml |
Adds allowBuilds configuration for pnpm 11 and retains catalog/overrides setup. |
pnpm-lock.yaml |
Lockfile re-resolved under pnpm 11; records vite/vitest overrides and dependency graph changes. |
packages/propel/vite.config.ts |
Removes the prior cached “run task” test runner configuration in favor of vp test. |
packages/propel/package.json |
Adds check/test/prepublishOnly scripts and new toolchain devDeps; updates Storybook script. |
package.json |
Updates the pnpm pin and removes the old pnpm.onlyBuiltDependencies field. |
.gitignore |
Stops ignoring .vscode/settings.json while continuing to ignore the rest of .vscode/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "tailwindcss": "^4.3.1", | ||
| "typescript": "^6.0.3", | ||
| "vite-plus": "catalog:", | ||
| "vitest": "4.1.9", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo was scaffolded with a stale pnpm pin and without the toolchain deps a Vite+ library declares, so this aligns it to what
vp create vite:monorepoproduces today (the monorepo template ships nopackageManagerfield; the CLI injects the current pnpm at scaffold time, which is now 11.7.0).Changes:
packageManager:pnpm@10.0.0->pnpm@11.7.0typescript,@typescript/native-preview,@types/node,bumpp,vite-plustest/check/prepublishOnlypackage scriptspackage.jsonpnpm.onlyBuiltDependenciesfield toallowBuildsinpnpm-workspace.yaml, which is where pnpm 11 reads it (esbuild/sharp/workerd build)vp testinstead of a custom Vite Task that shelled out to the rawvitestbinary. pnpm 11 no longer links that binary intonode_modules/.bin(the catalog aliasesvitestto@voidzero-dev/vite-plus-test), andvp testis the Vite+ convention anyway. It readstest.projectsfromvite.config.ts, so the four-theme matrix still runs.LAUNCH_EDITOR="$EDITOR"prefix on thestorybookscript.gitignore: stop ignoring.vscode/settings.jsonNotes for reviewers:
minimumReleaseAgecooldown, so the lockfile was rebuilt to resolve within policy.vp checkclean,vp run -r test700/700 across the four themes,vp run -r buildclean (attw passes).This touches the test config, so it overlaps
chore/storybook-theme-instances(PR #97 is separate; the theme-instances branch reworkstest.projects). Whichever lands first, I'll rebase the other so they don't collide.