fix transcript rendering edge cases#156
Open
Evanroby wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to go through the code a bit before using a library, and while doing that here I found a few issues worth cleaning up. This updates some rendering edge cases in transcripts, keeps sticker messages from replacing normal message content, fixes timestamp output, improves reply preview spacing, makes the webhook attachment retry path fail properly, and small component-related fixes..
that's all I could see by myself, and I just wanted those to be fixed to make it almost perfect. I have ran
ty checkcommand, but didn't know if you wanted me to resolve typechecking issuesafter-all, some fixes are imo and can be reverted, it's your choice
thanks for the library btw, I appreciate it, it's great !