Skip to content

fallback for some level corrupt in wsi#207

Merged
guillaumejaume merged 2 commits into
mahmoodlab:mainfrom
winglet0996:patch-1
Apr 20, 2026
Merged

fallback for some level corrupt in wsi#207
guillaumejaume merged 2 commits into
mahmoodlab:mainfrom
winglet0996:patch-1

Conversation

@winglet0996

@winglet0996 winglet0996 commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Hi, in this patch, line 214 to 231, provides a fallback of reading other level in some case that some level at the pyramid of wsi has corrupted.
Example slide for test: HANCOCK, PrimaryTumor_HE_232

@guillaumejaume

Copy link
Copy Markdown
Contributor

Thanks for the patch @winglet0996! Could you limit the PR to the read_region patch without including docstrings + _initialized changes.

Let me know if unclear
Best, Guillaume

@winglet0996

winglet0996 commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for your reply, I think the other messy changes stem from my local TRIDENT version is behind the current release and I've updated them for your review.
BTW, are you interested in a multi-GPU feature as in PR #181? It's an old PR and also has some conflicts now...

@guillaumejaume

Copy link
Copy Markdown
Contributor

Thanks @winglet0996!

Yes, happy to integrate multi GPU support too. I never had the chance to look at the code in details. Ping me when you have the conflicts merged. I think many users will be happy to use multi-gpu inference on large slides.

@winglet0996

Copy link
Copy Markdown
Contributor Author

Sounds great.
You may go ahead and merge this and your latest updates (like czi reader) to main first.​ I’ll then resolve the multi-GPU PR conflicts against the newest main branch.
Just let me know when things are ready, thank you.

@guillaumejaume guillaumejaume merged commit 26870f5 into mahmoodlab:main Apr 20, 2026
2 checks passed
@winglet0996 winglet0996 deleted the patch-1 branch April 20, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants