Repository navigation
test(flyway): replace deprecated initSql in the clean bootstrap - #275
Merged
Merged
Conversation
Replace deprecated initSql with a DataSource that runs PRAGMA foreign_keys = OFF before returning each connection. An AFTER_CONNECT callback is not sufficient: Flyway has already disabled auto-commit when it runs, so the driver begins a transaction before the pragma and SQLite ignores it. Document the pool/DataSource connection-init setup instead. Closes #273.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273.
What changed
FlywayKnownGapsITnow uses a DataSource that runsPRAGMA foreign_keys = OFFon each connection before returning it, instead of the deprecatedinitSql.README.mdrecommends a pool/DataSource connection-init statement (spring.datasource.hikari.connection-init-sql) and explains why anAFTER_CONNECTcallback is not enough: Flyway has already disabled auto-commit when it runs, so the driver starts a transaction before the pragma and SQLite ignores it.Verification
FlywayKnownGapsITandFlywayMigrationITagainst the pinned sqld container./mvnw -pl libsql-jdbc -am test./mvnw spotless:checkinitSqldeprecation warning remains.