fix(deps): update dependency io.netty:netty-codec-http [security]#256
Merged
magisk317 merged 1 commit intoJun 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the forced dependency version of io.netty:netty-codec-http from 4.1.133.Final to 4.1.135.Final in build.gradle.kts within both the buildscript and subprojects configurations. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.1.133.Final→4.1.135.FinalNetty: HttpObjectDecoder skips arbitrary initial control characters when only initial CRLF characters are permitted
CVE-2026-50020 / GHSA-hvcg-qmg6-jm4c
More information
Details
Summary
Before reading the first request-line,
HttpObjectDecoderskips every byte for whichCharacter.isISOControl(b)istrue(0x00–0x1F and 0x7F) as well as all whitespace.RFC 9112 §2.2 only asks servers to ignore empty CRLF lines preceding the request-line —
a carefully scoped robustness allowance intended to handle HTTP/1.0 POST workarounds.
Silently absorbing NUL bytes, SOH, STX, and other non-CRLF control characters goes
significantly beyond this, and can be exploited for request-boundary confusion in pipelined
or multiplexed transports where a front-end component treats those bytes differently.
Affected Code
codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.javaISO_CONTROL_OR_WHITESPACEstatic initialiser — marks all ISO control charscodec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.javaSKIP_CONTROL_CHARS_BYTESByteProcessor— skips the entire setcodec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.javaLineParser.skipControlChars— advancesreaderIndexpast all matching bytesSpecification Analysis
RFC 9112 §2.2 — Message Parsing
Deviation
The RFC names a single permitted exception: an empty line (bare CRLF, i.e. the two-byte
sequence
\r\n). TheISO_CONTROL_OR_WHITESPACEtable is initialised as:Character.isISOControlreturnstruefor0x00–0x1Fand0x7F. This includes NUL(
0x00), SOH (0x01), STX (0x02), BEL (0x07), DEL (0x7F), and every other non-CRLFcontrol character. The
SKIP_CONTROL_CHARSstate runs this scan unconditionally before thefirst
READ_INITIAL, meaning any sequence of such bytes prepended to a request is silentlyconsumed.
A load balancer or TLS terminator that does not perform the same scan sees a different
message boundary than Netty does, which is the basis of a request-desync / smuggling attack.
Suggested Unit Test
Add to
HttpRequestDecoderTest.java.Current behaviour (unfixed):
skipControlCharsadvances past0x00and0x01becauseboth are in
ISO_CONTROL_OR_WHITESPACE; the request parses normally,isFailure()isfalse→ test fails.Expected behaviour after fix: only CRLF empty lines are tolerated; non-CRLF control
bytes produce an error,
isFailure()istrue→ test passes.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate.