Skip to content

Switch to BIP39 word list by default#194

Draft
afontenot wants to merge 1 commit into
magic-wormhole:mainfrom
afontenot:bip39
Draft

Switch to BIP39 word list by default#194
afontenot wants to merge 1 commit into
magic-wormhole:mainfrom
afontenot:bip39

Conversation

@afontenot

Copy link
Copy Markdown
Contributor

Improves security slightly with default settings (16 bits -> 22 bits), and despite this the average word length is shorter (7.65 -> 5.40 chars) and (IMO) more easily remembered, communicated, and spelled.

Improves security slightly with default settings (16 bits -> 22 bits),
and despite this the average word length is shorter (7.65 -> 5.40 chars)
and (IMO) more easily remembered, communicated, and spelled.
@afontenot

Copy link
Copy Markdown
Contributor Author

I'm marking this as a draft because it's definitely unfinished (needs work on tests, etc), and also some feedback.

I realize BIP39 may not be the best theoretical wordlist approach, or anything like that, but IMO it's an easy change that's superior in every single way over the existing word list. It's worth moving to, even if it's ultimately temporary, for an easy win.

If you're interested in merging this, what would you like to do with the existing word list? Should it be left as dead code for some future word list switching feature? Removed?

@piegamesde

Copy link
Copy Markdown
Member

I'd like to point out #106 and magic-wormhole/magic-wormhole-protocols#31

@afontenot

Copy link
Copy Markdown
Contributor Author

Right, I had seen #106 before. I certainly see the appeal of three or four letter codes. My goal here was simply, while further changes are brewing, to go ahead and get an easy win while maintaining the current number-word-word format that users are used to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants