Add rabbit arm support#548
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bdf2b9393
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: Install RabbitMQ Erlang RPM for aarch64 | ||
| dnf: | ||
| allow_downgrade: no | ||
| disable_gpg_check: yes |
There was a problem hiding this comment.
This task explicitly disables package signature checks (disable_gpg_check: yes) even though the RabbitMQ signing key is imported just above, so the aarch64 path will accept an unsigned or tampered Erlang RPM if the download path is compromised. That weakens supply-chain protection specifically for ARM installs and is a regression from the repository-based signed install flow; keep GPG verification enabled and rely on the imported key.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This package is not signed so cannot be verified by gpg
MariuszJozwiak
force-pushed
the
dev-rabbitarm
branch
3 times, most recently
from
81be2c0 to
b24177f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b24177fc4f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| - name: Fetch latest RabbitMQ Erlang RPM release metadata for aarch64 | ||
| uri: | ||
| url: https://api.github.com/repos/rabbitmq/erlang-rpm/releases/latest |
There was a problem hiding this comment.
When rabbitmq_release is set to an intermediate series for the staged upgrade path this role documents (for example 3.13), this still asks GitHub for the latest Erlang RPM and installs that on aarch64. The current latest Erlang RPM line is 27.x, while RabbitMQ 3.13 supports Erlang 26.x only, so the later rabbitmq-server-3.13.* install can fail dependency checks or leave an unsupported RabbitMQ/Erlang combination during the required ARM upgrade stage. Choose the Erlang series from rabbitmq_release instead of always using /releases/latest.
Useful? React with 👍 / 👎.
MariuszJozwiak
force-pushed
the
dev-rabbitarm
branch
from
b24177f to
5fbfe42
Compare
MariuszJozwiak
force-pushed
the
dev-rabbitarm
branch
from
dc7b72d to
0869732
Compare
1 participant
No description provided.