Migrate to wasm-pack instead of manually calling wasm-bindgen and wasm-opt#936
Merged
Conversation
I originally migrated the original toolchain (wasm-bindgen-cli + wasm-opt from cargo), but wasm-opt hasn't had an update since 0.116.1 (2024-03) since it was moved to the binaryen project, which is now at 0.130. The recommended toolchain has become wasm-pack (https://github.com/wasm-bindgen/wasm-pack). See https://blog.rust-lang.org/inside-rust/2025/07/21/sunsetting-the-rustwasm-github-org/. This resolves the issue on Arch BTW, where... something happens on GCC 16 while attempting to compile wasm-opt. See WebAssembly/binaryen#8559. This commit also greatly simplifies the build steps, because wasm-pack will pick to run wasm-opt depending on the build variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate off manually calling wasm-bindgen-cli and wasm-opt.
I originally migrated the original toolchain (wasm-bindgen-cli + wasm-opt
from cargo), but wasm-opt hasn't had an update since 0.116.1 (2024-03)
since it was moved to the binaryen project, which is now at 0.130. The
recommended toolchain has become wasm-pack.
See https://blog.rust-lang.org/inside-rust/2025/07/21/sunsetting-the-rustwasm-github-org/.
This resolves the issue on Arch BTW, where... something happens on GCC
16 while attempting to compile wasm-opt. See WebAssembly/binaryen#8559.
This commit also greatly simplifies the build steps, because wasm-pack
will pick to run wasm-opt depending on the build variant.
Pull Request Checklist
Please check one of the boxes below: