Skip to content

chore: remove attach_user_permissions#5051

Merged
whutchinson98 merged 2 commits into
mainfrom
whutchinson98/chore-remove-unused-middleware
Jul 21, 2026
Merged

chore: remove attach_user_permissions#5051
whutchinson98 merged 2 commits into
mainfrom
whutchinson98/chore-remove-unused-middleware

Conversation

@whutchinson98

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9439e774-451a-4f1f-9c27-ff2b1615e917

📥 Commits

Reviewing files that changed from the base of the PR and between 3f0918e and 124f7f1.

📒 Files selected for processing (6)
  • crates/macro_middleware/Cargo.toml
  • crates/macro_middleware/src/lib.rs
  • crates/macro_middleware/src/user_permissions/attach_user_permissions.rs
  • crates/macro_middleware/src/user_permissions/mod.rs
  • services/document_storage_service/Cargo.toml
  • services/mcp_service/Cargo.toml
💤 Files with no reviewable changes (2)
  • crates/macro_middleware/src/user_permissions/mod.rs
  • crates/macro_middleware/src/user_permissions/attach_user_permissions.rs

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Removed the user permissions middleware and related request processing.
    • User permissions are no longer enabled through the combined middleware configuration.
  • Chores
    • Updated service configuration to stop requesting the removed user permissions capability.
    • Reorganized dependency declarations for consistency without changing functionality.

Walkthrough

The macro middleware crate no longer includes user_permissions in the all feature or public module exports. Its user permissions submodule declaration was removed. The document storage service stopped enabling that feature, and its dependency entries were reordered. The MCP service manifest dependency entries and feature-array formatting were reorganized without changing the declared dependencies or feature values.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, so its relation to the changeset cannot be meaningfully assessed. Add a brief description summarizing the middleware and feature removals.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title uses a valid conventional-commits prefix and clearly matches the middleware cleanup.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@whutchinson98
whutchinson98 merged commit b6e3314 into main Jul 21, 2026
27 checks passed
@whutchinson98
whutchinson98 deleted the whutchinson98/chore-remove-unused-middleware branch July 21, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant