Skip to content

test(soup): cover row-click fallback location routing#5045

Merged
evanhutnik merged 1 commit into
mainfrom
evan/soup-fallback-tests
Jul 20, 2026
Merged

test(soup): cover row-click fallback location routing#5045
evanhutnik merged 1 commit into
mainfrom
evan/soup-fallback-tests

Conversation

@evanhutnik

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #5044, which merged while CodeRabbit's review suggestion was being addressed.

  • Extracts the row-click snippet-hit fallback from openEntityInSplitFromUnifiedList into a pure getRowClickFallbackLocation helper (behavior unchanged) so it can be unit tested.
  • Adds regression tests covering the routing behavior from fix(email): open search thread results at latest message expanded #5044: email rows never derive a target message from their snippet hit (they open at the latest message), call rows keep the snippet-hit fallback, and entities without hits or search data yield no location.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6dbb20b3-8073-49fd-8bbf-ca0b727ecf3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Added the exported getRowClickFallbackLocation helper to derive fallback search locations for non-email snippet entities. Updated unified-list split opening to use the helper when no explicit location is provided. Added tests covering email, call record, missing-hit, and non-snippet entity behavior.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly matches the row-click fallback routing changes.
Description check ✅ Passed The description directly describes the helper extraction and regression tests in this changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@evanhutnik
evanhutnik force-pushed the evan/soup-fallback-tests branch from e319c3f to b82011f Compare July 20, 2026 20:12
@evanhutnik
evanhutnik merged commit 4769baf into main Jul 20, 2026
24 checks passed
@evanhutnik
evanhutnik deleted the evan/soup-fallback-tests branch July 20, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant