Skip to content

fix(search): stop indexing canvas content#5028

Merged
gbirman merged 1 commit into
mainfrom
gbirman/macro-2472-search-stop-indexing-canvas-content-keep-canvas-names-only
Jul 20, 2026
Merged

fix(search): stop indexing canvas content#5028
gbirman merged 1 commit into
mainfrom
gbirman/macro-2472-search-stop-indexing-canvas-content-keep-canvas-names-only

Conversation

@gbirman

@gbirman gbirman commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Canvas documents now index via the existing parent-only path, so names remain searchable without emitting canvas content chunks. Removed the unused canvas parser and kept canvas delete-before-upsert behavior for reindex cleanup.

@macro-application

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 013ddd2f-7f96-4a82-ab91-8a20d167944d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Removed the canvas JSON parser and its public module export. Updated raw document processing to route FileType::Canvas through parent-only indexing, removed canvas content-chunk generation, and added tests for the resulting empty content, identifiers, raw content, and properties.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses a conventional commit prefix and clearly describes the canvas indexing change.
Description check ✅ Passed The description matches the change set by explaining parent-only canvas indexing and removal of the canvas parser.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@services/search_processing_service/src/process/document/raw_document.rs`:
- Around line 618-633: The inline tests module containing
test_canvas_routes_to_parent_only_indexing and
test_generate_canvas_parent_only_upsert_has_no_content_chunk should be moved
into a sibling test.rs module file. Replace the inline implementation with
#[cfg(test)] mod test; and preserve the tests’ existing behavior and access to
the parent module’s symbols.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 842995bb-984d-4c36-b8d9-60aa21fb7906

📥 Commits

Reviewing files that changed from the base of the PR and between 33e6818 and 97cc715.

📒 Files selected for processing (3)
  • services/search_processing_service/src/parsers/canvas.rs
  • services/search_processing_service/src/parsers/mod.rs
  • services/search_processing_service/src/process/document/raw_document.rs
💤 Files with no reviewable changes (2)
  • services/search_processing_service/src/parsers/mod.rs
  • services/search_processing_service/src/parsers/canvas.rs

Comment thread services/search_processing_service/src/process/document/raw_document.rs Outdated
@gbirman
gbirman force-pushed the gbirman/macro-2472-search-stop-indexing-canvas-content-keep-canvas-names-only branch 2 times, most recently from 46b868a to fa4dcb0 Compare July 20, 2026 15:36
@gbirman
gbirman force-pushed the gbirman/macro-2472-search-stop-indexing-canvas-content-keep-canvas-names-only branch from fa4dcb0 to 02b81ba Compare July 20, 2026 15:41
@gbirman
gbirman merged commit 6cdfbd2 into main Jul 20, 2026
25 checks passed
@gbirman
gbirman deleted the gbirman/macro-2472-search-stop-indexing-canvas-content-keep-canvas-names-only branch July 20, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant