fix(search): stop indexing canvas content#5028
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughRemoved the canvas JSON parser and its public module export. Updated raw document processing to route 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@services/search_processing_service/src/process/document/raw_document.rs`:
- Around line 618-633: The inline tests module containing
test_canvas_routes_to_parent_only_indexing and
test_generate_canvas_parent_only_upsert_has_no_content_chunk should be moved
into a sibling test.rs module file. Replace the inline implementation with
#[cfg(test)] mod test; and preserve the tests’ existing behavior and access to
the parent module’s symbols.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 842995bb-984d-4c36-b8d9-60aa21fb7906
📒 Files selected for processing (3)
services/search_processing_service/src/parsers/canvas.rsservices/search_processing_service/src/parsers/mod.rsservices/search_processing_service/src/process/document/raw_document.rs
💤 Files with no reviewable changes (2)
- services/search_processing_service/src/parsers/mod.rs
- services/search_processing_service/src/parsers/canvas.rs
46b868a to
fa4dcb0
Compare
fa4dcb0 to
02b81ba
Compare
Canvas documents now index via the existing parent-only path, so names remain searchable without emitting canvas content chunks. Removed the unused canvas parser and kept canvas delete-before-upsert behavior for reindex cleanup.