Repository navigation
Fix Inspector updates after SubclassSelector type changes - #113
Merged
Merged
Conversation
Why Asynchronous type selection applied the serialized value outside the owning property GUI scope, so consumers such as TriInspector retained stale validation. What Changed Keep the pending change in Unity GUI control state so it survives drawer replacement, then report it through the owning property change check. Exercise real popup input for type changes, null selection and cancellation. Impact Inspector consumers receive ordinary field change notifications without a third-party dependency or a new public API.
Why The new property interaction tests require an Editor GUI view, which cannot be initialized with -nographics. What Changed Run Linux EditMode tests under Xvfb with software OpenGL and document the corresponding local graphics requirement. Impact Both supported Unity versions exercise real popup input in the existing test matrix and remain covered by the final Verification check.
Owner
Author
|
Pre-merge verification completed for commit Independent review and the final diff check found no actionable issues. Both Linux EditMode jobs pass (Unity 2021.3.45f2: 50/50; Unity 2023.2.22f1: 53/53), and the final Verification check passes. The added popup interaction tests verify the caller-visible change notification; type and null selection fail against the original implementation and pass with this fix. Merging to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidateInputand dynamicInfoBoxmessages.Scope
-nographics.Verification
ValidateInput, dynamicInfoBox, andOnValueChanged; the standardPropertyFieldconsumer also observes the change. In this reproduction, dirty state andOnValidatealready updated before the fix.Verificationpassed.References
EndChangeCheckand evaluates InfoBox through its validator. Both attributes cache their validation results. Its current 2.0 preview uses a different UI Toolkit update path and was inspected as source only.Closes #88