chore: generate artifact attestations for release assets#2183
Open
scop wants to merge 1 commit into
Open
Conversation
https://docs.github.com/en/actions/concepts/security/artifact-attestations This makes use of workflow artifacts to accomplish generating a single combined attestation for all release assets. Generating one per asset is kind of an antipattern, could at present generate one for successful matrix entries even when some others in it fail, as well as require id-token and attestations permission for the build process. Doing it this way with workflow artifacts is a bit clunky, but it currently serves as a widely used workaround for inability to nicely set and consume multiple outputs from matrix builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/concepts/security/artifact-attestations
This makes use of workflow artifacts to accomplish generating a single combined attestation for all release assets. Generating one per asset is kind of an antipattern, could at present generate one for successful matrix entries even when some others in it fail, as well as require id-token and attestations permission for the build process. Doing it this way with workflow artifacts is a bit clunky, but it currently serves as a widely used workaround for inability to nicely set and consume multiple outputs from matrix builds.
Python wheel builds already have the attestations, per the maturin generated workflow.
Caveat: untested, but I suppose it could work. Anyway as the asset job is a separate one after release builds, a failure in it should not prevent GitHub release from succeeding.