Improve dijkstra#58
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a bidirectional version of Dijkstra’s algorithm, updates the UI to use it, and ensures basic testing and CI are in place.
- Implement
bidirectional_dijkstraalongside updates to the existingdijkstrafunction. - Swap calls in
ui.rsfromdijkstratobidirectional_dijkstra. - Add a simple
GridPointtest and include tests in CI.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ui.rs | Imported and invoked bidirectional_dijkstra instead of dijkstra. |
| src/dijkstra.rs | Added bidirectional_dijkstra, refactored dijkstra, and added timing. |
| src/test.rs | Added basic equality tests for GridPoint. |
| src/main.rs | Registered test module under cfg(test). |
| .github/workflows/ci.yml | Added a step to run cargo test --all in CI. |
Comments suppressed due to low confidence (1)
src/test.rs:3
- The new
bidirectional_dijkstrafunction isn’t covered by any tests. Consider adding tests that verify it returns the same path as the unidirectional version on simple graphs.
#[test]
lukacslacko
approved these changes
Jun 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… it outside of bidirectional_dijkstra function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a bidirectional Dijkstra, and use PriorityQueue.push_increase