Reduce overload during parallelization #150
Open
Andreas-Piter wants to merge 8 commits into
Open
Conversation
…native threading of scipy.
…native thread default to 1. Fix bug in densification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many steps of SARvey are parallelized either explicitly using multiprocessing or with native-threading of external libraries such as scipy or numpy. While the number of cores for parallel processing with multiprocessing can be adjusted in the configuration file, the number of cores for native parallelization, i.e.
had to be set outside in the environment. Now, the number of cores for native threads are set inside SARvey to the given number of cores from the config, but only if it was not set before in the environment variables. Thereby, the user has full control.
To reduce computational overhead, the number of cores is explicitly adjusted to the number of tasks done in parallel.
However, computational overhead might still happen for processing steps in which multiprocessing and native threads are used in parallel. Optimal balance between these two are is still to be determined by experiments.
Type of change
Checklist