Skip to content

fix: defer Google marker add until custom view lays out #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lodev09 merged 2 commits into from
Sep 28, 2026
Merged

fix: defer Google marker add until custom view lays out #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2502819
fix(ios): defer Google marker add until custom view lays out
lodev09 Sep 28, 2026
92ea99d
fix(android): skip pending custom markers until laid out
lodev09 Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion android/src/main/java/com/luggmaps/core/GoogleMapProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,11 @@ class GoogleMapProvider(private val context: Context) :

private fun processPendingMarkers() {
if (googleMap == null) return
pendingMarkerViews.forEach { addMarkerViewToMap(it) }
pendingMarkerViews.forEach {
// markerViewDidLayout adds it once the bitmap can be drawn
if (it.hasCustomView && !it.didLayout) return@forEach
addMarkerViewToMap(it)
}
pendingMarkerViews.clear()
}

Expand Down
5 changes: 5 additions & 0 deletions ios/core/GoogleMapProvider.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,11 @@ - (void)addMarkerViewToMap:(LuggMarkerView *)markerView {
if (!_mapView)
return;

// Custom icons rasterize from layout; adding before that shows the SDK's
// default pin until markerViewDidLayout re-syncs.
if (markerView.hasCustomView && !markerView.didLayout)
return;

GMSAdvancedMarker *marker = [[GMSAdvancedMarker alloc] init];
marker.position = markerView.coordinate;
marker.title = markerView.title.length > 0 ? markerView.title : nil;
Expand Down
Loading