Skip to content

fix(ci): Inno Setup launcher exe path #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstein merged 2 commits into from
Jun 7, 2026
Merged

fix(ci): Inno Setup launcher exe path #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a6dcf
fix(ci): pass absolute paths to Inno Setup so it finds the launcher exe
lstein Jun 7, 2026
612680f
fix(ci): retry artifact downloads to survive transient 5xx
lstein Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/deploy-launcher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Fetch uv ${{ env.UV_VERSION }}
run: |
mkdir -p launcher/assets
curl -fsSL -o /tmp/uv.tar.gz \
curl -fsSL --retry 5 --retry-all-errors --retry-delay 5 -o /tmp/uv.tar.gz \
"https://github.com/astral-sh/uv/releases/download/${UV_VERSION}/uv-x86_64-unknown-linux-gnu.tar.gz"
tar -xzf /tmp/uv.tar.gz --strip-components=1 -C launcher/assets uv-x86_64-unknown-linux-gnu/uv
mv launcher/assets/uv launcher/assets/uv-bin
Expand All @@ -81,7 +81,7 @@ jobs:

- name: Build AppImage
run: |
curl -fsSL -o /tmp/appimagetool \
curl -fsSL --retry 5 --retry-all-errors --retry-delay 5 -o /tmp/appimagetool \
"https://github.com/AppImage/appimagetool/releases/download/continuous/appimagetool-x86_64.AppImage"
chmod +x /tmp/appimagetool
export PATH="/tmp:$PATH"
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
mkdir -p launcher/assets
# macos-latest runners are Apple Silicon (arm64). Intel Macs are not
# covered by this build; add an x86_64 leg / universal2 if needed.
curl -fsSL -o /tmp/uv.tar.gz \
curl -fsSL --retry 5 --retry-all-errors --retry-delay 5 -o /tmp/uv.tar.gz \
"https://github.com/astral-sh/uv/releases/download/${UV_VERSION}/uv-aarch64-apple-darwin.tar.gz"
tar -xzf /tmp/uv.tar.gz --strip-components=1 -C launcher/assets uv-aarch64-apple-darwin/uv
mv launcher/assets/uv launcher/assets/uv-bin
Expand Down Expand Up @@ -241,9 +241,14 @@ jobs:
shell: pwsh
run: |
choco install innosetup --no-progress -y
# Inno resolves relative paths against the .iss file's folder, so pass
# absolute paths for the source exe and the output dir (repo-root dist).
$exe = (Resolve-Path dist\photomap.exe).Path
$out = (Resolve-Path dist).Path
& "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" `
"/DAppVersion=$env:VERSION" `
"/DSourceExe=dist\photomap.exe" `
"/DSourceExe=$exe" `
"/O$out" `
INSTALL\launcher\windows\photomap.iss

- name: Sign installer (Azure Trusted Signing)
Expand Down
Loading