Experimental encoding of provenance multiblock files as parquet#568
Draft
dhirving wants to merge 4 commits into
Draft
Experimental encoding of provenance multiblock files as parquet#568dhirving wants to merge 4 commits into
dhirving wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
- Coverage 88.81% 88.60% -0.21%
==========================================
Files 160 161 +1
Lines 22357 22394 +37
Branches 2657 2663 +6
==========================================
- Hits 19856 19842 -14
- Misses 1861 1906 +45
- Partials 640 646 +6 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick experiment to try writing the provenance multiblock files as parquet instead of a custom binary format. It's using the new Variant column type to work with the JSON data previously stored in the multiblock files. (These would be better as hand-crafted parquet schemas, but that would take a lot longer to try.)
So far it gives about 3x better compression for the dataset and quanta files. And the query required by DM-55322 becomes a one-liner that executes in 15 seconds against ~23 million rows.
Haven't tested random access yet, but the theory is that we will sort the files and just use the row group indexes to do the lookups by UUID.
Doesn't work at all for metadata and logs -- those are large blobs that don't really make sense in parquet. The files get larger and its hard to get the parquet encoder to not run out of memory when writing them.
Checklist
package-docs builddoc/changes