Skip to content

DM-55080: Fix LSSTCam serial numbers to match the file headers#717

Merged
timj merged 4 commits into
mainfrom
tickets/DM-55080
May 28, 2026
Merged

DM-55080: Fix LSSTCam serial numbers to match the file headers#717
timj merged 4 commits into
mainfrom
tickets/DM-55080

Conversation

@timj

@timj timj commented May 27, 2026

Copy link
Copy Markdown
Member
  • Detector 173 was wrong. It had been replaced in Jan 2020 but we got the old value.
  • The entries for rafts R24 and R34 were swapped.

@ktlim

ktlim commented May 27, 2026

Copy link
Copy Markdown
Contributor

R34S22 was 311
R24S22 is 385???

@timj

timj commented May 27, 2026

Copy link
Copy Markdown
Member Author

R24_S22 is 385:

  "MC_O_20250427_000372_R24_S22.fits": {
    "PC2_2A": 0.0,
    "SEQFILE": "FP_E2V_2s_l3cp_v30.seq",
    "CRVAL1C": 4005.0,
    "CRVAL2B": 4005.0,
    "PC1_2C": -1.0,
    "PC2_1E": 0.0,
    "PC2_2Q": -1.0,
    "FIRMWARE": "3139500e",
    "PC1_1E": -1.0,
    "PC2_2C": 0.0,
    "DETSEC": "[512:1,1:2002]",
    "DETSIZE": "[1:4096,1:4004]",
    "CRVAL1B": 523.0,
    "PC2_1B": 0.0,
    "PC1_1B": -1.0,
    "DATASEC": "[11:522,1:2002]",
    "RAFTBAY": "R24",
    "DTV1": 523,
    "PC2_1A": -1.0,
    "PC2_1R": -1.0,
    "PC2_2E": -1.0,
    "CRVAL2R": 9050.0,
    "CRVAL1E": 59850.0,
    "CCD_MANU": "E2V",
    "PC2_2F": 0.0,
    "SEQNAME": "FP_E2V_2s_l3cp_v30.seq",
    "PC1_1Q": -1.0,
    "CHECKSUM": "5CTL6BTI5BTI5BTI",
    "FILENAME": "MC_O_20250427_000372_R24_S22.fits",
    "CRVAL2A": 523.0,
    "RAFTNAME": "LCA-11021_RTM-016",
    "PC1_1R": 0.0,
    "ZDATASUM": "1916043626",
    "PC1_1C": 0.0,
    "CCD_TYPE": "CCD250",
    "LSST_NUM": "E2V-CCD250-385",

I assume we didn't change things again in the last year. This was a 2025 header I was looking at.

@timj

timj commented May 27, 2026

Copy link
Copy Markdown
Member Author

R34_S22:

  "MC_O_20250427_000372_R34_S22.fits": {
    "PC2_2A": 0.0,
    "SEQFILE": "FP_E2V_2s_l3cp_v30.seq",
    "CRVAL1C": 4005.0,
    "CRVAL2B": 4005.0,
    "PC1_2C": -1.0,
    "PC2_1E": 0.0,
    "PC2_2Q": -1.0,
    "FIRMWARE": "3139500e",
    "PC1_1E": -1.0,
    "PC2_2C": 0.0,
    "DETSEC": "[512:1,1:2002]",
    "DETSIZE": "[1:4096,1:4004]",
    "CRVAL1B": 523.0,
    "PC2_1B": 0.0,
    "PC1_1B": -1.0,
    "DATASEC": "[11:522,1:2002]",
    "RAFTBAY": "R34",
    "DTV1": 523,
    "PC2_1A": -1.0,
    "PC2_1R": -1.0,
    "PC2_2E": -1.0,
    "CRVAL2R": 9050.0,
    "CRVAL1E": 59850.0,
    "CCD_MANU": "E2V",
    "PC2_2F": 0.0,
    "SEQNAME": "FP_E2V_2s_l3cp_v30.seq",
    "PC1_1Q": -1.0,
    "CHECKSUM": "hNBEkL99hLAChL79",
    "FILENAME": "MC_O_20250427_000372_R34_S22.fits",
    "CRVAL2A": 523.0,
    "RAFTNAME": "LCA-11021_RTM-008",
    "PC1_1R": 0.0,
    "ZDATASUM": "1921022098",
    "PC1_1C": 0.0,
    "CCD_TYPE": "CCD250",
    "LSST_NUM": "E2V-CCD250-134"

@timj

timj commented May 27, 2026

Copy link
Copy Markdown
Member Author

I agree that S22 was not a swap.

@jchiang87 jchiang87 self-requested a review May 27, 2026 22:36

@jchiang87 jchiang87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the CCDs swap between R24 and R34, the raftSerial numbers also need to be swapped:
R24.yaml should have

raftSerial : LCA-11021_RTM-016

and R34.yaml should have

raftSerial : LCA-11021_RTM-008

Otherwise, everything else looks ok.

In addition to the CCDs swap between R24 and R34, the raftSerial numbers also need to be swapped#
@timj

timj commented May 27, 2026

Copy link
Copy Markdown
Member Author

@jchiang87 I made the changes.

One wrinkle: lsstCamSim is explicitly soft linking to lsstCam and so now all those serials have changed. Should I unlink the two and have it use the historical values or let it drift?

@timj

timj commented May 27, 2026

Copy link
Copy Markdown
Member Author

(I noticed because a couple of years ago you added to git the combined camera model by mistake even though it's a generated file)

@jchiang87

Copy link
Copy Markdown
Contributor

I'd keep them linked. LsstCamSim only really cares about the gain and read noise values in those files, which haven't changed.

Ok to merge from my perspective.

Other camera files are not added
@timj timj merged commit 4858fb1 into main May 28, 2026
3 checks passed
@timj timj deleted the tickets/DM-55080 branch May 28, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants