a few llvm19 api change#48
Open
707state wants to merge 1 commit into
Open
Conversation
lsegal
requested changes
Apr 17, 2024
lsegal
left a comment
lsegal
left a comment
Owner
There was a problem hiding this comment.
Remove hard coded paths and this can be merged.
| @@ -0,0 +1,92 @@ | |||
| [ | |||
| { | |||
| "directory": "/home/sgj/codes/fy/my_toy_compiler", | |||
Owner
There was a problem hiding this comment.
This should be updated to avoid hard coding paths or this entire file should be removed since it's not related to the changes.
Author
There was a problem hiding this comment.
my bad. I'll be careful next time.
| "file": "parser.cpp" | ||
| }, | ||
| { | ||
| "directory": "/home/sgj/codes/fy/my_toy_compiler", |
| }, | ||
| { | ||
| "directory": "/home/sgj/codes/fy/my_toy_compiler", | ||
| "arguments": [ |
| }, | ||
| { | ||
| "directory": "/home/sgj/codes/fy/my_toy_compiler", | ||
| "arguments": [ |
| "file": "corefn.cpp" | ||
| }, | ||
| { | ||
| "directory": "/home/sgj/codes/fy/my_toy_compiler", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little api change and works fine with llvm19.