[i2c, dv] I2C V1 sign-off#616
Conversation
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
2090013 to
0541ff3
Compare
KinzaQamar
requested review from
elliotb-lowrisc,
marnovandermaas and
martin-velay
| [i2c_bind.sv]: ../../hw/vendor/lowrisc_ip/ip/i2c/dv/sva/i2c_bind.sv | ||
| [tb.sv]: ../../hw/vendor/lowrisc_ip/ip/i2c/dv/tb/tb.sv | ||
| [I2C DV document]: ../../hw/vendor/lowrisc_ip/ip/i2c/dv/README.md | ||
| [I2C testplan]: ../../hw/vendor/lowrisc_ip/ip/i2c/data/i2c_testplan.hjson |
There was a problem hiding this comment.
Duplicated link (already defined at line 80)
|
|
||
| *Checklist to be defined — see [stages.md][verification stages].* | ||
|
|
||
| [COSMIC reports dashboard]: https://private.reports.lowrisc.org |
There was a problem hiding this comment.
That's our internal link, only accessible by us. You should change it into:
| [COSMIC reports dashboard]: https://private.reports.lowrisc.org | |
| [COSMIC reports dashboard]: https://dashboard.reports.lowrisc.org/cosmic/mocha/dashboard.html |
There was a problem hiding this comment.
This links gives a report on 29/4. Just a summary of percentage and not what is passing and failing? Do we have a proper public dashboard?
There was a problem hiding this comment.
Yes I have shared this issue already with @machshev, he's on holidays but I guess he'll take a look later. If you prefer you can say that you've checked on our private regressions and provide the date and share the Git hash mentioned in there, as such lowRISC fellows can cross-check at least. But please keep the public dashboard link as done in the template
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
0541ff3 to
eddb068
Compare
2 participants
No description provided.