[dv] V1 signoff for GPIO block#611
Open
martin-velay wants to merge 1 commit into
Open
Conversation
KinzaQamar
reviewed
Jun 16, 2026
KinzaQamar
reviewed
Jun 16, 2026
Signed-off-by: martin-velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
gpio_v1_signoff
branch
from
213a2d3 to
d30f147
Compare
KinzaQamar
approved these changes
Jun 17, 2026
KinzaQamar
left a comment
KinzaQamar
left a comment
Contributor
There was a problem hiding this comment.
I am not super familiar with signoffs but approving as this looks sensible to me
Contributor
Author
|
@tchilikov-semify, we need 3 reviewers for the signoffs. Could you take a look? Basically, you need to double check if what I said is true and see if it's clear enough. |
tchilikov-semify
approved these changes
Jun 18, 2026
tchilikov-semify
left a comment
tchilikov-semify
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Some comments from my end.
|
|
||
| GPIO is auto-generated for Mocha from OpenTitan's [`ip_templates/gpio`][OT template]. | ||
| The block provides 32 configurable general-purpose I/O pins with configurable per-pin interrupt detection (rising edge, falling edge, level-high, level-low), direct and masked output modes, an optional 16-cycle noise filter, and hardware strap sampling. | ||
| It connects to the Mocha peripheral fabric via TileLink-UL through `xbar_peri` and carries one alert channel. |
Collaborator
There was a problem hiding this comment.
I wouldn't mention the alert, since this is not connected in Mocha.
| The block provides 32 configurable general-purpose I/O pins with configurable per-pin interrupt detection (rising edge, falling edge, level-high, level-low), direct and masked output modes, an optional 16-cycle noise filter, and hardware strap sampling. | ||
| It connects to the Mocha peripheral fabric via TileLink-UL through `xbar_peri` and carries one alert channel. | ||
| The DV environment reuses the CIP-based UVM infrastructure from OpenTitan. | ||
| Mocha applies a single patch (`0001_fix_paths_and_tool.patch`) to adjust paths and toolchain integration; no RTL logic is modified. |
Collaborator
There was a problem hiding this comment.
Put a link to the patch?
| ### D1 | ||
|
|
||
| The sign-off checklist items are described in the [D1 design sign-off checklist][D1 checklist]. | ||
| This sign-off is based on commit [`1234def`][d1-commit] (nightly yyyy-mm-dd). |
Collaborator
There was a problem hiding this comment.
This looks a bit weird. Maybe instead of copying the table here we should just say that D1 hasn't been started yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close issue #164