Add manticore header to unit tests to avoid transient error#205
Merged
alexcams merged 2 commits intoOct 17, 2025
Conversation
Member
|
Tests are failing due to fixture certs expiring, please run spec/filters/fixtures/generate_test_certs.sh and commit the new certs to this PR |
alexcams
force-pushed
the
fix-unit-tests-transient-error-uninitialized-manticore
branch
from
5295e29 to
f9d7b79
Compare
alexcams
pushed a commit
to alexcams/logstash-filter-elasticsearch
that referenced
this pull request
Jan 22, 2026
…#234) Provide field value tracking, persisted to disk on each search_after page. Adds `:last_value` and `:present` placeholders, allowing the plugin to inject the cursor value and now-30 seconds, respectively, in the query string. Useful to track new data being written to an index or series of indices. Works best with nano second precision timestamps added by Elasticsearch's Ingest Pipelines. --------- Co-authored-by: Joel Andritsch <joel.andritsch@gmail.com> Co-authored-by: Rob Bavey <rob.bavey@elastic.co> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a CI transient error while executing elasticsearch_spec.rb unit tests that was making pipelines fail from time to time:
Uninitialized Manticore error
This is a concurrency error caused by the indirect inclusion of Manticore library while calling this function that is called by many tests in
elasticsearch_spec.rbfile. Since the tests execution does not always follow the same order, the problem comes if any test that useManticore::Clientclass is executed before calling this function that indirectly includes theManticorelibrary, it causes this class to be "uninitialized".To solve this transient error, I've just included the
Manticorelib at the beginning of the file.Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/