Create type definition#19
Conversation
|
@smusali if you have time to review |
|
Just a little ping to get some feedback, thanks! |
|
Another ping just to make sure I am not forgotten |
|
@smusali Let me know if you prefer that I copy the props from the parent, otherwsie feel free to merge. |
smusali
left a comment
smusali
left a comment
There was a problem hiding this comment.
Let's have a complete conversion and then merge!
|
Dear @smusali, I hope you will the changes to you liking. Please see my comment above concerning a potential bug with defaults. I am also starting to consider that maybe the options interface should not inherit from the parents since it's particular mix of both (the case of |
That's fine! I'll have a couple of requests as well |
smusali
left a comment
smusali
left a comment
There was a problem hiding this comment.
Well, in order to keep consistency, I'm trying to compare it with our Node.js Code Library to which the types have already been added and most probably, after publishing the new version of logdna-winston including this addition, I'll do the same for our Bunyan Support as well. So, a few things I wanna request:
- Please, specify the types inside
package.jsonsimilar to this - This captures
Loggermodule's methods as well; so, here we can seeLogDNATransporthas alogmethod but it looks like it's inherited fromTransportand it's already defined here; so, there is no need to capture it separately, right? Can you confirm it, please?
Thanks!
| interface TransportOptions | ||
| extends Transport.TransportStreamOptions, | ||
| ConstructorOptions { | ||
| /** The LogDNA API key. */ |
There was a problem hiding this comment.
it looks like there is some kinda indentation issue here - can you fix?
|
@smusali I think it would be best if you take over, I do not have the bandwidth to go back and forth over this issue anymore. Thanks! |
|
@smusali can you please merge this? |
4 participants
Fixes #18