Skip to content

Export TypeScript Types, Minor Code Housekeeping#13

Open
prescience-data wants to merge 4 commits into
logdna:mainfrom
prescience-data:main
Open

Export TypeScript Types, Minor Code Housekeeping#13
prescience-data wants to merge 4 commits into
logdna:mainfrom
prescience-data:main

Conversation

@prescience-data

Copy link
Copy Markdown

Implements:

  • Fixes TypeScript exports
  • Consolidates dangling types
  • Adds typed Exceptions
  • Inlines some verbose code
  • Adds lint to npm commands

Suggestions:

  • Would be good to implement some ESLint rules to avoid contributors IDEs messing with code style (some things that prettier doesn't catch).
  • With typed Exceptions added, may be worth adding specific error instanceof checks in certain places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant