Skip to content

Remove duplicate from opts.py#324

Open
AlexKurek wants to merge 1 commit into
lofar-astron:masterfrom
AlexKurek:Remove-duplicate-from-opts
Open

Remove duplicate from opts.py#324
AlexKurek wants to merge 1 commit into
lofar-astron:masterfrom
AlexKurek:Remove-duplicate-from-opts

Conversation

@AlexKurek

@AlexKurek AlexKurek commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

The same is just above this.
The test is failing for unrelated reasons.
It's strange that the tests are failing though, as nothing has been changed since the last merged PR.
EDIT: 99% this is becouse they released numpy 2.5 yesterday.

@gmloose gmloose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a copy/paste error. This change indeed shouldn't trigger an error.

@AlexKurek

Copy link
Copy Markdown
Contributor Author

The test failed due to #325, so unrelated reason.

@gmloose

gmloose commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Well, from the logs it looks like the test failed because comparison to the reference output failed:

[7](https://github.com/lofar-astron/PyBDSF/actions/runs/27932069892/job/82645793872?pr=324#step:7:158)
ERROR [root]: Image files 'tbdsf_process_image.in_fits_pybdsf/residual/tbdsf_process_image.in_fits.pybdsf.resid_gaus.fits' and 'reference_outputs/residual/tbdsf_process_image.in_fits.pybdsf.resid_gaus.fits' differ (rtol=0.01)
Noise: 0.811 mJy/b vs 0.834 mJy/b
ERROR [root]: Image files 'tbdsf_process_image.in_fits_pybdsf/wavelet/tbdsf_process_image.in_fits.pybdsf.atrous.w2.fits' and 'reference_outputs/wavelet/tbdsf_process_image.in_fits.pybdsf.atrous.w2.fits' differ (rtol=0.01)
Noise: 0.270 mJy/b vs 0.274 mJy/b
ERROR [root]: Image files 'tbdsf_process_image.in_fits_pybdsf/wavelet/tbdsf_process_image.in_fits.pybdsf.atrous.w3.fits' and 'reference_outputs/wavelet/tbdsf_process_image.in_fits.pybdsf.atrous.w3.fits' differ (rtol=0.01)
Noise: 0.214 mJy/b vs 0.218 mJy/b

We're these files updated recently?

BTW: when building wheels (using cibuildwheel) on my machine, the same test passes. So I doubt that this failure is related to #325.

@AlexKurek

AlexKurek commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

In my case, installed locally today PyBDSF was crashing and it worked after #325.
Maybe Numpy 2.5 also changed something else, not only np.cross().

BTW: when building wheels (using cibuildwheel) on my machine, the same test passes

Maybe there is still numpy <2.5 there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants