Remove duplicate from opts.py#324
Open
AlexKurek wants to merge 1 commit into
Open
Conversation
gmloose
approved these changes
Jun 22, 2026
gmloose
left a comment
Collaborator
There was a problem hiding this comment.
Looks like a copy/paste error. This change indeed shouldn't trigger an error.
Contributor
Author
|
The test failed due to #325, so unrelated reason. |
Collaborator
|
Well, from the logs it looks like the test failed because comparison to the reference output failed: We're these files updated recently? BTW: when building wheels (using |
Contributor
Author
|
In my case, installed locally today PyBDSF was crashing and it worked after #325.
Maybe there is still numpy <2.5 there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same is just above this.
The test is failing for unrelated reasons.
It's strange that the tests are failing though, as nothing has been changed since the last merged PR.
EDIT: 99% this is becouse they released numpy 2.5 yesterday.