Remove fftconvolve#323
Open
AlexKurek wants to merge 2 commits into
Open
Conversation
Collaborator
|
@darafferty, what about this unused |
Contributor
|
I've been looking at the convolution (#326 ) and it seems scipy is the simplest choice as well as having performance which is competitive. The memory saving of inplace multiply in the hand-rolled fftconvolve surprisingly has a performance impact (did not trace exactly why) so I think would be of interest in only quite limited circumstances. So I would suggest removing the fftconvolve() is a good move. |
Collaborator
|
Yes, I agree it is best to remove it, as I can't see it ever being used. |
Contributor
Author
|
I have changed this PR to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.complexwas removed in Numpy 1.24.Currently
fftconvolveis not used sincescipy.signal.fftconvolveis used, but still maybe better to fix it.An alternative / next step could be to remove
fftconvolvefunction.