Skip to content

Update reference output files#314

Merged
darafferty merged 1 commit into
masterfrom
update_reference_output
Jun 17, 2026
Merged

Update reference output files#314
darafferty merged 1 commit into
masterfrom
update_reference_output

Conversation

@darafferty

Copy link
Copy Markdown
Collaborator

This PR updates the reference files used for the CI tests. The files changed due to the fixes applied in #309.

@darafferty darafferty requested a review from gmloose June 16, 2026 10:39

@gmloose gmloose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you approved #309, I guess it makes sense to (blindly) approve this MR.

I do wonder, though, what the impact of #309 will be in practice, on real data? There, exceptions may have escaped unnoticed as well.

@darafferty

Copy link
Copy Markdown
Collaborator Author

I tested the changes on a few real images that I think are representative and found that they worked fine. If things are worse in some way due to the fixes, we can always adjust things ( e.g., the way the flagging is done) to make the results more similar to those before the fixes.

@darafferty darafferty merged commit efdd116 into master Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants