Fix statistics of the residual image#299
Open
AlexKurek wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
The test is failing for unrelated reasons ( #309 (comment) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First:
resid_gaus = cp(img.ch0_arr)Later the algorithm checks if the mask is defined. If it is, it injects "new" NaNs into
resid_gausThe algorithm tries to isolate the non-Nan pixels:
resid_gaus_non_masked = resid_gaus[N.where(~N.isnan(img.ch0_arr))The problem is, that it searches for the pixels that are not NaN in the original image. But "other" NaNs were added to
resid_gausin(1). Soresid_gaus_non_maskedstill may have NaNs. In that case laterN.mean(),N.std()etc. will return NaN-s for the entire array.EDIT:
Reverted Same for shapelets since it crashes the test. Maybe lets stick to
resid_gausin this PR.