Repository navigation
Conversation
Both booted a bare example as stage2 (derive-probe, blockdev-probe); 9167e6e deleted those probes (and reboot-probe, read_all_pcrs) but left the targets, so both have failed at `cargo build --example` since. test-pivot is the full-chain test and covers their ground through the real loader. Keep the shared STAGE0_*/STAGE1_*/SERVE_HOST/PERSIST_GROW it uses; drop the PAYLOAD/PERSIST_PAYLOAD defaults. PCR-BINDING.md: remove the reproduce section, which pointed at the deleted target and probe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Folded into #2 (one PR per repo for this changeset). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-chain-%andtest-persist-%booted a bare example binary as stage2:derive-probe(TPM derive determinism plus PCR15 key binding) andblockdev-probe(GPT rebuild, dm-crypt and a sentinel on a grown disk).9167e6e(XTS/meta_bg rework) deleted those probes, along withreboot-probeandtpm_derive::read_all_pcrs, but left the targets. Both have failed atcargo build --exampleever since.test-pivotis the full-chain test (stage0 -> UKI -> stage1 -> packed loader ->pivot-init) and covers their ground through the real loader. It is untouched.STAGE0_*/STAGE1_*/SERVE_HOST/PERSIST_GROW, whichtest-pivotuses. Dropped thePAYLOAD/PERSIST_PAYLOADdefaults, which nothing else uses.PCR-BINDING.md: removed the "How to reproduce / investigate" section, which pointed at the deleted target and probe. If that analysis is needed again, the test can be recreated.Test plan
read_all_pcrsmake -n test-pivot-x86_64still resolvesmake ci🤖 Generated with Claude Code