You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changeset looks good overall- one super-teeny finding for your consideration:
The default IGNORE_PATHS="docs/" will also ignore docs/pom.xml, which the _binary-dist_ build needs to order its modules (or build.xml/requirements.txt`), so a PR that needed to update the docs 'build' components would also fail to build- Could narrow the scope to documentation content only, i.e. *.rst, to honor the intent of the change if you think it matters.
Changeset looks good overall- one super-teeny finding for your consideration:
The default IGNORE_PATHS="docs/" will also ignore docs/pom.xml, which the _binary-dist_ build needs to order its modules (or build.xml/requirements.txt`), so a PR that needed to update the docs 'build' components would also fail to build- Could narrow the scope to documentation content only, i.e. *.rst, to honor the intent of the change if you think it matters.
Thanks, I think that's fine as the 'docs' CI will still run it - the dist modules take the output but don't care about any actual changes to the docs for their own build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.