Fix Key Concepts tab color and card/image height mismatch#71
Merged
Conversation
Active tab fill was a solid near-black pill, too heavy for the section's light theme — swapped for a soft teal tint matching the existing CTA button style. More substantially: the side-by-side card's height was still an independently-guessed value even after the media-width fix in 0.4.2, which meant a true 16:9 image either came up shorter than the card (a visible letterboxing gap) or forced a crop. The card's height is now media's own aspect-ratio-derived height, and the text column's typography is fluid (CSS container query units) so it scales to fit whatever height that produces instead of demanding a fixed floor — which is what forced the letterbox-vs-crop tradeoff in the first place. Zero crop and zero letterboxing at every width from 1200px up; the narrow-desktop stacked tier absorbs the range where side-by-side genuinely can't fit legible text beside an uncropped image (901-1199px, down from 901-1299px).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun run test— 20/20 smoke tests passbunx playwright test— 22/22 e2e tests pass, including 2 new regression tests (mobile tab strip legibility, and true-16:9-no-letterbox)