Repository navigation
Conversation
Adds a standalone English source for seireitranslations.blogspot.com, a Blogger site. Each novel is one of the blog's labels, and its chapters are the posts under that label. Browse, search, novel detail with the full chapter list, and chapter text are all served from the Blogger feeds and post pages. Labels that are not English novel text are left out: the "[Bahasa Indonesia]" translations, the untagged Indonesian labels, and the image-only manhwa labels. Closes lnreader#160
RibatTRW
marked this pull request as draft
October 15, 2026 12:09
[Medium impact] The PR appears safe to merge; no blocking issue was established. SummaryAdds Seirei Translations as an English source.
No actionable issues were established. Reviews (2) · Last reviewed commit: "no-mistakes(document): Clarify seirei la..." · Reviewed by Greptile |
RibatTRW
marked this pull request as ready for review
October 15, 2026 13:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
Summary
Adds a standalone English source plugin for https://seireitranslations.blogspot.com/ (a Blogger site).
[Bahasa Indonesia]labels, untagged Indonesian labels (ChroNoiR, Lagu, Back Then I Adored You), and image-only manhwa labels (The Great Wish, Rainy Night). That leaves 11 novels.public/static/src/en/seireitranslations/icon.png(96x96, upscaled from the site's 32px favicon).Testing
npm ci, thennpm run build:full: exit 0.npm run check:plugin -- plugins/english/seireitranslations.ts: all four steps PASS against the live site.Screenshots
Captured headless in the repo's Plugin Playground (the Vite dev server UI), with the playground's proxy origin pointed at a local dev server. These are not screenshots from the LNReader app. The Android toolchain is not installed on the machine used, so no in-app test was run.
Popular listing with covers (playground, Seirei Translations)
Novel detail with its chapter list (Chiyu Mahou no Machigatta Tsukaikata, 163 chapters)
Chapter readable text (Parse Chapter, Chiyu chapter 346)
Search results (Bokutachi)
AI disclosure
This change was written with AI assistance (Claude). It has not been reviewed by a human maintainer.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
plugins/english/seireitranslations.ts:33- Hardcoded EXCLUDED_LABELS set (lines 33-39) and the image-only acceptance in parseChapter (line 202-203) are product-scope choices the intent does not require. The intent only asks for the site as a source with English chapter text. The set drops five Blogger labels by exact name, and the comment (lines 29-31) says manhwa labels are dropped because they hold only images, yet parseChapter still accepts image-only chapters. Any new non-novel label (music, tags, future manhwa) will show as a novel, and the list must be edited by hand. The smallest honest remedy is to remove EXCLUDED_LABELS and rely on the NON_ENGLISH_TAG filter plus the existing chapter text check, so the exclusion is not a second catalogue rule. Authorizing the removal or keeping the list is the author's call.🔧 Fix applied.
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
npm ci (dependency install, lockfile untouched)npm run check:plugin -- plugins/english/seireitranslations.ts (live site: popularNovels 11, searchNovels 2 for 'Bokutachi no Remake', parseNovel 169 chapters, parseChapter 13029 chars: all PASS)Playground served by vite on port 3917 (port 3000 was already occupied by another process, left untouched); playground's hardcoded localhost:3000 CORS-proxy calls rerouted to 3917 via Chromium CDP Fetch interception (no source edits)Headless Chromium driven over CDP (/tmp/seirei-cdp/driver): Popular > Fetch shows 11 Seirei novels with coversSearch tab, term 'remake' returns 'Bokutachi no Remake' and 'Bokutachi no Remake Ver. β'Parse Novel with /search/label/Bokutachi%20no%20Remake returns 169 chapters, first chapter Apr 28 2021, ordered oldest firstParse Chapter with /2026/10/bokutachi-no-remake-volume-9-chapter5-2.html renders 44496 characters of English text with translator credits and body paragraphsAdversarial: search 'zzqxnovelnotathing' shows 'No results found'Adversarial: Parse Chapter with https://example.com/... shows 'Seirei Translations: invalid page address.'Adversarial: Parse Chapter with /2026/10/does-not-exist-zz.html shows 'Seirei Translations: HTTP 404.'Adversarial: Parse Novel with /not-a-label/xyz shows 'Seirei Translations: invalid novel address.'Adversarial: search 'chronoir' and 'indonesia' show no results (excluded labels and [Bahasa Indonesia] labels hidden); search 'great wish' shows only '[Novel] The Great Wish'Verified raw Blogger label list via curl: Bahasa Indonesia and excluded labels are present upstream and are filtered by the pluginReview-round-1 decision: HEAD comment already states the real reason for label exclusion and does not claim image-only chapters are rejected; no further change neededTest servers and Chromium stopped; worktree git status clean (node_modules and generated files are gitignored)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.