Repository navigation
Conversation
Standalone English plugin for thesylthorian.com, the author's Squarespace storefront. Browses the free web-novel catalogue, parses each novel's chapter list, reads chapter text, and searches the catalogue by title. Co-authored-by: opencode-agent <noreply@opencode.ai>
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds The Sylthorian as an English source.
No actionable issues found. This review checked code only; live behavior and the icon’s appearance were not independently verified. Reviews (2) · Last reviewed commit: "no-mistakes(review): remove unrequired t..." · Reviewed by Greptile |
RibatTRW
marked this pull request as draft
October 15, 2026 12:06
RibatTRW
marked this pull request as ready for review
October 15, 2026 13:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
Screenshot source: the screenshots referenced below come from the repository's Plugin Playground (
npm run dev:start, headless Chromium), not from the LNReader app. The Android toolchain is not installed here, so no in-app screenshots exist.Screenshots (plugin playground, headless Chromium)
These come from the repository's Plugin Playground, not the LNReader app.
/web-novels:/web-novels-1/100luck, showing the cover, summary and chapter list:/latest-chapters/100luck-1, showing readable chapter text:luckreturns 100 Luck and the Dragon Tamer Skill!:Intent
Work on #66 and include screenshots of the working fix in the PR.
Issue 66, "[Source Request] The Sylthorian" (English, opened five years ago, no comments, no linked PR): the reporter asks for The Sylthorian as a source and links https://thesylthorian.com/web-novels. Today no plugin and no generated source covers the site, so the request is still open. The site is live and serves readable free web chapters - verified this week: https://thesylthorian.com/web-novels returns 200; a novel's page is /web-novels-1/; chapter pages are /latest-chapters/-N, and https://thesylthorian.com/latest-chapters/100luck-1 returns 200 with the chapter title "~ Chapter 1: The Ominous Message! ~". The site is the author's own storefront: the free web chapters are readable, while some books there are sold rather than readable.
Make sure the fix's pull request shows a photo of the plugin working correctly inside the plugin playground, and run that screenshot process headless if possible.
What Changed
plugins/english/sylthorian.tsfor thesylthorian.com. Popular and search results come from the single/web-novelscatalogue page, with search filtering that list by title, and covers fall back todefaultCoverbecause the listing exposes none.<h2>, the cover fromog:image(upgraded to HTTPS), the "Synopsis:" block as the summary, and the/latest-chapters/<slug>-Nlinks as chapters numbered fromN. Chapter pages return the Squarespace post body and throw when it is missing. Non-OK HTTP responses throw with the status code.public/static/src/en/sylthorian/icon.png.Risk Assessment
✅ Low: The change adds a single new standalone plugin and a 96x96 icon with no shared-code edits; both prior-round fixes (numeric-only chapter suffix, removal of secondary selectors) are present in the current code, and I found no reachable wrong-result path in the new code.
Testing
The plugin passes the live checker and every end-user scenario I could drive live through the real playground in headless Chromium: popular list, search (match and no-match), novel parsing with cover, summary and ascending chapters, chapter body, and explicit 404 errors for missing novels and chapters. The prefix-collision guard was exercised only with the bundled plugin against a canned fixture, so it is untested live. Three screenshots are in the evidence directory. Note: an early attempt to attach to the browser bridge hit a Chromium already running on port 9333 that belongs to another session, so some playground interactions and one page reload happened in that browser before I detected it. I did not close or modify that browser; my bridge was detached and all later driving used my own Chromium on port 9676.
npm run check:pluginpop…~/.no-mistakes/evidence/01M4ZNC3T19MKJ7G56FSTQ17FV/01-popular-novels.png)~/.no-mistakes/evidence/01M4ZNC3T19MKJ7G56FSTQ17FV/02-parse-novel-100luck.png)~/.no-mistakes/evidence/01M4ZNC3T19MKJ7G56FSTQ17FV/03-parse-chapter-100luck-1.png)Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed (2) ✅
plugins/english/sylthorian.ts:151- parseChapters matchesa[href^="/latest-chapters/<slug>-"]and keeps every match even when the suffix is not numeric (the chapterNumber regex only guards the number, not inclusion). A novel slug that is a hyphen-prefix of another novel slug (e.g.maandma-xyz) would list/latest-chapters/ma-xyz-1undermawith no chapterNumber. Current catalog slugs (100luck, blessing, cop9, dkr, ehv, es, foe, gdw, ma, smdq) have no such pair, so this is latent. Fix: only push the chapter when the suffix matches /^\d+$/ (the same regex already computed at lines 154-158), or otherwise reject non-numeric suffixes. Same invariant applies to the only other chapter-collecting path, which is parseChapters itself (single call site at parseNovel, line 124).🔧 Fix applied.
2 warnings still open:
plugins/english/sylthorian.ts:151- parseChapters matchesa[href^="/latest-chapters/<slug>-"]and keeps every match even when the suffix is not numeric (the chapterNumber regex only guards the number, not inclusion). A novel slug that is a hyphen-prefix of another novel slug (e.g.maandma-xyz) would list/latest-chapters/ma-xyz-1undermawith no chapterNumber. Current catalog slugs (100luck, blessing, cop9, dkr, ehv, es, foe, gdw, ma, smdq) have no such pair, so this is latent. Fix: only push the chapter when the suffix matches /^\d+$/ (the same regex already computed at lines 154-158), or otherwise reject non-numeric suffixes. Same invariant applies to the only other chapter-collecting path, which is parseChapters itself (single call site at parseNovel, line 124).plugins/english/sylthorian.ts:205- Simplification: the secondary fallbacks in parseNovel (themeta[itemprop="name"]title fallback, plugins/english/sylthorian.ts:~205-210) and parseChapter (the.blog-item-contentfallback when.sqs-html-contentis absent, ~line 230) are not required by the stated intent, which only needs the free web chapters readable from the verified/latest-chapters/<slug>-Npages. Remedy: remove them and keep the single primary selector per field, unless the author wants them as deliberate resilience against Squarespace template changes.🔧 Fix applied.
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
npm run check:pluginpop…npm run check:plugin -- plugins/english/sylthorian.ts(live site: popularNovels PASS 10 novels, searchNovels PASS, parseNovel PASS 167 chapters, parseChapter PASS 18011 chars)npm run dev:startgave a playground, then a dedicatednpx vite --host 127.0.0.1 --port 3000 --strictPortin the worktree, because another session holds [::1]:3000 and the playground's CORS is hard-wired to localhost:3000Headless Chromium 152 with a throwaway profile, driven via chrome-devtools-axi: Plugin list filtered to 'Sylthorian' and selected (?plugin=sylthorian)Popular tab: Fetch → 10 novel cards with default covers (screenshot 01)Search tab: 'magic' → 'I was reincarnated as a Magic Academy!'; 'zzqqxx' → 'No results found'Parse Novel tab: '/web-novels-1/100luck' → title '100 Luck and the Dragon Tamer Skill!', cover, summary, 'Chapters (137)' starting at 'Chapter 1: The Ominous message' (screenshot 02)Parse Chapter tab: '/latest-chapters/100luck-1' → 'CHAPTER CONTENT (7269 characters)' starting with the chapter body (screenshot 03)Adversarial: Parse Novel '/web-novels-1/doesnotexist-xyz' → 'Request failed: 404'Adversarial: Parse Chapter '/latest-chapters/100luck-99999' → 'Request failed: 404'Adversarial (non-live fixture): bundled plugin via esbuild with a stub @libs/fetch serving a 'ma' page that also links '/latest-chapters/ma-xyz-1' and 'ma-xyz-2' → parseNovel returned only ma-1, ma-2, ma-10 with chapterNumberCleanup: stopped the dedicated vite server, the loopback forwarder and the Chromium instance; removed gitignored multisrc outputs under plugins/ and temp profiles✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.