Repository navigation
Conversation
Author
|
Handle: nul-quill. Payout wallets: Solana USDC BdznDjc4xwt5Y6WJT5UnrFQzDptka8YnC9oqmmkKpwkd, TRC20 TNEHCVwR2aPMrj5AKfWCQ2rFL3bEDQmsg7. |
An account whose status is not `active` (new / pending / locked / closed)
cannot use received funds, yet both hops of a Lightning Address payment
answered for it:
- `GET /pay/lnurl/:username` decoded the stored lnurlp and minted an invoice
through IBEX for any account the username resolved to.
- `accountDefaultWallet` handed back the wallet — and with it `lnurlp` — of an
inactive account, which is what a sending wallet then posts against.
Both now run `AccountValidator(account).isActive()` immediately after the
username lookup and before any wallet lookup or IBEX call. The LNURL proxy
answers in the LUD-01 error shape (`{ status: "ERROR", reason: ... }`) so
sending wallets render the reason instead of a bare failure; the GraphQL query
throws the mapped `InactiveAccountError`, the GraphQL counterpart of the same
refusal.
`addInvoiceForSelf` already guarded this way; the two lookup paths were the
ones left out.
nul-quill
force-pushed
the
inactive-lnurl-76
branch
from
October 11, 2026 18:57
41336c7 to
97793f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76.nnBoth hops of a Lightning Address payment answered for accounts that cannot use what they receive. GET /pay/lnurl/:username decoded the stored lnurlp and minted an IBEX invoice for any account the username resolved to, and �ccountDefaultWallet handed back that account's wallet (and its lnurlp) for a sending wallet to post against.nnBoth now run AccountValidator(account).isActive() immediately after the username lookup and before any wallet lookup or IBEX call - the same guard �ddInvoiceForSelf already used. The LNURL proxy answers in the LUD-01 error shape so wallets render the reason; the GraphQL query throws the mapped InactiveAccountError, the GraphQL counterpart of the same refusal.nnRegression coverage:
ew / pending / locked / closed all refuse without reaching Ibex.decodeLnurl or the presentation resolver, and �ctive still serves.