Repository navigation
feat: expand Ask Flash navigation and guided actions - #810
Merged
Merged
Conversation
Contributor
|
this PR needs to be updated to follow conventional commits message |
islandbitcoin
changed the title
islandbitcoin
changed the title
islandbitcoin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask Flash could answer basic questions but could not open most named screens or complete common requests such as “Convert 20 USD to BTC,” “Cash out $50,” or “Add Alice to my contacts.”
This adds deterministic, offline-capable navigation to 26 stable screens and the existing in-app support chat. Explicit USD↔BTC swap requests and cash-outs prepare the existing review cards; the user supplies a missing amount in the thread and must still tap Confirm after reviewing the destination and fees. Merchant requests show live map merchants by name with an Open Map action. “Show my last payment to Alex” searches the existing transaction rails and presents selectable history rows. Flashcard top-ups pass an exact amount into the existing card flow, where the user reviews it and taps the card.
Chat contact requests resolve the Flash username through NIP-05 before displaying an Add, Remove, or Open profile action. Removal requires a separate confirmation; contact updates preserve other Nostr tags and require an accepted relay publication. No model can infer a payee, account, contact, or amount for these actions. Live merchant, cash-out, and contact operations require a connection; saved payment reads retain the existing offline behavior.
Validation:
yarn check-code, translation drift, changed-file lint, 91 assistant suites (1,971 tests), and the Flashcard top-up screen suite (including prefilled amount) passed.