[HIP] introduce TEST_SUITE_HIP_MANAGED_DIR and use it for Kokkos#421
Open
jplehr wants to merge 1 commit into
Open
[HIP] introduce TEST_SUITE_HIP_MANAGED_DIR and use it for Kokkos#421jplehr wants to merge 1 commit into
jplehr wants to merge 1 commit into
Conversation
Add a single, build-dir-independent location for tool-managed dependencies that are downloaded or generated (and thus safe to delete). Redirect the Kokkos ExternalProject there via PREFIX so its sources survive `rm -rf build/` instead of being re-cloned on every reconfigure. First step toward a shared download location for all External/HIP components.
Kewen12
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a single, build-dir-independent location for tool-managed dependencies that are downloaded or generated (and thus safe to delete). Redirect the Kokkos ExternalProject there via PREFIX so its sources survive
rm -rf build/instead of being re-cloned on every reconfigure. First step toward a shared download location for all External/HIP components.This is the first one in a set of patches with the intention to unify the way in where we store downloaded things. Following patches will make use of this location for: Ginkgo sources, catch2 sources, therock-clone, rocm-libraries clone.
AI-assisted.