[HIP] Enable multi-version catch tests#420
Open
jplehr wants to merge 3 commits into
Open
Conversation
Address various places where -${VARIANT_SUFFIX} appears to have been
missing. This is a problem when running in an environment with multiple
different ROCm versions installed.
jplehr
force-pushed
the
fix/enable-multi-version-catch-tests
branch
from
caa7d16 to
60ad61e
Compare
Contributor
Author
|
There is one change that is not "just a fix": The patch introduces the |
jmmartinez
reviewed
Jun 10, 2026
jmmartinez
left a comment
jmmartinez
left a comment
Contributor
There was a problem hiding this comment.
I just left a minor comment. Otherwise, the changes look reasonable to me.
It seems that none of the steering variables to enable external test suites had an option. I took the liberty to add all of the options in this commit together with cleaning up one misplaced `include`.
jplehr
commented
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address various places where -${VARIANT_SUFFIX} appears to have been missing. This is a problem when running in an environment with multiple different ROCm versions installed.