fix(webview): hide progress bar on main-frame load errors#36
Open
jim-daf wants to merge 1 commit into
Open
Conversation
ProgressBarWebViewClient shows the spinner on onPageStarted and hides it on onPageFinished. On some failure modes the WebView reports the failure through onReceivedError and skips onPageFinished, so the spinner stays visible over a blank WebRegisterActivity / PrivacyPolicyActivity. The user has no way to know the page never loaded. Add a main-frame-only onReceivedError override that hides the progress bar too. isForMainFrame keeps a blocked sub-resource from hiding the spinner while the main load is still running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
ProgressBarWebViewClientshows the progress bar ononPageStartedand hides it ononPageFinished. On some failure modes the WebView reports the failure throughonReceivedErrorand skipsonPageFinished, so the spinner stays visible over a blankWebRegisterActivity/PrivacyPolicyActivity. The user has no way to know the page never loaded.Add a main-frame-only
onReceivedErroroverride that hides the progress bar too:isForMainFramekeeps a single blocked sub-resource from hiding the spinner while the main load is still running. No callers of the client are affected.