Fix axom::copy so it can be called from OpenMP loop#1894
Merged
Conversation
kennyweiss
approved these changes
Jun 26, 2026
rhornung67
reviewed
Jun 29, 2026
|
|
||
| // Resolve Umpire's fallback HOST path once so the first threaded axom::copy() | ||
| // cannot race through lazy resource creation. | ||
| std::call_once(once, []() { |
rhornung67
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1724 where using
axom::copyfrom an OpenMP loop when Umpire is enabled can result in a fatal problem where multiple threads attempt to construct the Umpire resource manager.std::call_onceinitialization to get the Umpire objectsaxom::copy.